[Backport release-24.11] chromium: remove ofborg maintainer ping workaround, use CODEOWNERS #362678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nixpkgs-ci[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
The workaround to have ofborg ping chromium and ungoogled-chromium maintainers when a change was only made to the upstream-info relied on string context. That string context was provided by the upstream-info being a nix file, not a json file, and then holding on to that string context using awkward attribute merges. It was intended as a quick fix until the handling of this would improve in ofborg itself and worked great. That was until very recently when we switched from the chromium release tarball to git source fetching in 8dd2f1a. Part of that change included going back from upstream-info.nix to upstream-info.json and with that losing the string context and the base on which this workaround used to work. But this is fine. A lot has happened in the meantime. CODEOWNERS was reimplemented and no longer requires every user listed in it to have write permissions to the repository (commit bit). Meaning we can accept that ofborg pings no longer work and instead rely on CODEOWNERS exclusively. It should, however, be noted that CODEOWNERS provide less granularity than ofborg, meaning we can no longer differentiate between ungoogled-chromium and chromium or even chromedriver. Previously, implementing the workaround that is now essentially reverted: 68c5979 (cherry picked from commit 674835a)
13 tasks
github-actions
bot
added
the
6.topic: continuous integration
github-actions
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #362543.