nixos/hickory-dns: make settings.zone freeform; expose configFile option
#363001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like the toplevel hickory-dns.settings, options here are handled by the hickory-dns binary: users should be able to specify options that the nixos module has overlooked.
github-actions
bot
added
6.topic: nixos
this allows users the option to configure hickory-dns manually, for example from the .toml files specified in hickory-dns examples directory.
uninsane
force-pushed
the
pr-hickory-dns-improvements
branch
from
7da1cb7 to
9117dd6
Compare
misuzu
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to #362891
settingsitself is freeform; thatsettings.zoneis not was a mistake. everything insettingsis handled by hickory-dns and the user should be free to specify options not known to nixos.configFilegives users a way to configure hickory-dns outside of nixos, e.g. to deploy the example configs from hickory-dns, or as an escape hatch should the nixos module contain other bugs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.