qownnotes: fix build for macOS

[pbek]

This should fix the build on macOS, where there is no xvfb-run. Or is this only an issue on aarch64 darwin, @wineee?
(See pbek/QOwnNotes#2912 (comment))

But

nixpkgs/pkgs/tools/misc/xvfb-run/default.nix

Line 60 in 22c3f2c

platforms = platforms.linux;

told me there is no xvfb-run.

@sfatula, maybe you want to test this build?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pbek]

@wineee, @sfatula, sorry for the spam because of the two broken PRs!

[getchoo]

I think it would also be worth checking if the Darwin executable will spit out the completions without this command -- or if there is an alternative for xquartz as mentioned in the issue

[getchoo]

Log

-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_tl.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_fil.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ceb.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_hi.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_hil.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ur.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_fi.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_el.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_gl.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_no.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_da.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ro.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_sl.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_sk.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_eu.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_sr.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_fa.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ha.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_bg.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_is.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_pa.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_sq.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_he.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_yi.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_th.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_sn.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_km.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_si.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_zu.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_xh.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ms.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_mi.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ga.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_uz.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_vi.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_lv.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ku.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_lt.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_bs.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_mk.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_ko.qm
-- Installing: /nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/share/qt6/translations/QOwnNotes_et.qm
mv: cannot stat '/nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/bin/QOwnNotes.app': No such file or directory

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363327

---

aarch64-darwin

❌ 1 package failed to build:

• qownnotes

[pbek]

@getchoo, so do you have Apple Silicon hardware? That's amazing! Thank you for testing!

mv: cannot stat '/nix/store/1fq8jcv4ziaf16d5c5a7748jlvgpr2j7-qownnotes-24.11.2/bin/QOwnNotes.app': No such file or directory

Yes, we just saw that in pbek/QOwnNotes#2912 (comment).

Can the paths in

nixpkgs/pkgs/applications/office/qownnotes/default.nix

Lines 67 to 72 in 22c3f2c

	# Wrap application for macOS as lowercase binary
	+ lib.optionalString stdenv.hostPlatform.isDarwin ''
	mkdir -p $out/Applications
	mv $out/bin/${appname}.app $out/Applications
	makeWrapper $out/Applications/${appname}.app/Contents/MacOS/${appname} $out/bin/${pname}
	'';

be adapted to work for aarch64-darwin?

But why did it ever work on x86_64-darwin? 🤔

[wineee]

@ofborg build qownnotes

[getchoo]

But why did it ever work on x86_64-darwin? 🤔

Seems it doesn't anymore

My guess is that is the .app bundle is actually in $out/${appname}.app rather than mv $out/bin/${appname}.app

[pbek]

@ofborg build qownnotes

[pbek]

I played around in a GitHub workflow, the build should work now, including shell completion.
https://github.com/pbek/QOwnNotes/actions/runs/12243377462

[pbek]

Thank you!