Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nvidia: add nvidia_dc_565 drivers #363367

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

edwtjo
Copy link
Member

@edwtjo edwtjo commented Dec 8, 2024

Also remove dc_520 and use nixfmt on module and driver files.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware 6.topic: nvidia labels Dec 8, 2024
@edwtjo edwtjo force-pushed the nvidia_dc-565 branch 3 times, most recently from 085b521 to 4ec9b33 Compare December 8, 2024 21:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Dec 8, 2024
@ofborg ofborg bot requested a review from Kiskae December 9, 2024 17:52
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 9, 2024
Kiskae

This comment was marked as outdated.

Copy link
Contributor

@Kiskae Kiskae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master and move the formatting to a separate commit.

In addition I'm not sure its a good idea to add even more variations to the builder when a regular runfile is available.

pkgs/os-specific/linux/nvidia-x11/builder.sh Outdated Show resolved Hide resolved
pkgs/os-specific/linux/nvidia-x11/default.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Dec 13, 2024
@edwtjo
Copy link
Member Author

edwtjo commented Dec 13, 2024

Please rebase on master and move the formatting to a separate commit.

Done

In addition I'm not sure its a good idea to add even more variations to the builder when a regular runfile is available.

Right and I agree, this was done in haste without much reflection.. I believe I've addressed your comments. This will still need some more testing, which I intend to do next week.

@misuzu misuzu added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 14, 2024
pkgs/top-level/linux-kernels.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/video/nvidia.nix Show resolved Hide resolved
pkgs/os-specific/linux/nvidia-x11/default.nix Show resolved Hide resolved
@edwtjo edwtjo force-pushed the nvidia_dc-565 branch 2 times, most recently from 176e8f2 to ecf217e Compare December 18, 2024 11:14
@edwtjo edwtjo force-pushed the nvidia_dc-565 branch 2 times, most recently from 45efa35 to 3979f12 Compare December 18, 2024 20:59
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 19, 2024
@edwtjo
Copy link
Member Author

edwtjo commented Dec 19, 2024

All checks have been passed, both maintainers approve on the changes, bundled services tested in datacenter.

@edwtjo edwtjo merged commit 438969f into NixOS:master Dec 19, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: hardware 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nvidia 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants