-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nvidia: add nvidia_dc_565 drivers #363367
Conversation
085b521
to
4ec9b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on master
and move the formatting to a separate commit.
In addition I'm not sure its a good idea to add even more variations to the builder when a regular runfile is available.
4ec9b33
to
277ad0d
Compare
Done
Right and I agree, this was done in haste without much reflection.. I believe I've addressed your comments. This will still need some more testing, which I intend to do next week. |
176e8f2
to
ecf217e
Compare
45efa35
to
3979f12
Compare
3979f12
to
38b4018
Compare
38b4018
to
843f154
Compare
All checks have been passed, both maintainers approve on the changes, bundled services tested in datacenter. |
Also remove dc_520 and use nixfmt on module and driver files.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.