Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ankama-launcher #363509

Closed
wants to merge 1 commit into from
Closed

Update ankama-launcher #363509

wants to merge 1 commit into from

Conversation

Antoinemarteau
Copy link

Update needed.

The launcher has been updated, I re generated the web-archive downloading and updated sha.

@Antoinemarteau
Update ankama-launcher
15e6dc7 
Update needed.
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 9, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
getchoo
getchoo reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our commit conventions, it would be better for the commit and PR title to be in the format of something like ankama-launcher: 3.12.24 -> 3.12.25 or ankama-launcher: update hash

And welcome to Nixpkgs!

pkgs/by-name/an/ankama-launcher/package.nix
Comment on lines +15 to +16
url = "https://web.archive.org/web/20241209091715/https://launcher.cdn.ankama.com/installers/production/Ankama%20Launcher-Setup-x86_64.AppImage";
hash = "sha256-ii156AkxkqNCFmcMwfYn8AMX3/vJWUDKRbF6Cs0QIYw=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change come with an actual version bump of the launcher? If not that's fine, just checking :p

@Gliczy
Copy link
Member

Gliczy commented Dec 9, 2024

Welcome to nixpkgs!

The latest version of ankama-launcher is already merged with #362515.

Also, your changes are not targeting the right branch. Most changes should go in master, if the changes causes mass rebuilds, then it should go in staging.
Your commit message is also not following the commit convention.

You can read more about that in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md.

@GaetanLepage
Copy link
Contributor

Welcome and thanks for the PR.
I will however close it for the reasons mentioned above.
I updated ankama-launcher to 3.12.26 in #362515.

Update PRs need to target master.

@Antoinemarteau Antoinemarteau deleted the patch-1 branch December 9, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Antoinemarteau @Gliczy @GaetanLepage @getchoo @NixOSInfra