Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technititum-dns-server: 13.2 -> 13.2.2 #363529

Closed

Conversation

FabianRig
Copy link
Contributor

Update Technitium DNS Server and its library to 13.2.2.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 10, 2024
@SuperSandro2000 SuperSandro2000 changed the title technititum-dns-server: 13.2 --> 13.2.2 technititum-dns-server: 13.2 -> 13.2.2 Dec 13, 2024
@FabianRig
Copy link
Contributor Author

@SuperSandro2000 Thank you for your review! I've applied all changes, but now the build is failing. Perhaps because of

inherit (technitium-dns-server) version;

?

Any suggestions what to edit/add, please?

@timhae
Copy link
Contributor

timhae commented Dec 14, 2024

Yes, you need to pass in the package at the top so callPackage picks it up but then you might have an infinite recursion.. Which would speak for merging the packages again.. And then create an update script that updates both

@FabianRig
Copy link
Contributor Author

OK. I'd like to wait if @SuperSandro2000 has an idea how to solve this elegantly. If not, I'd close this PR and probably go back to joining the two packages again. :-(

@timhae
Copy link
Contributor

timhae commented Dec 15, 2024

I asked in matrix, there doesn't seem to be a way. You can join the packages again and I will try to create an update script that covers both

@FabianRig
Copy link
Contributor Author

@timhae: Could you please check #365428 and review it?

@FabianRig FabianRig closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants