Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam-devices-udev-rules: init at 1.0.0.61-unstable-2024-05-22; nixos/hardware.steam-hardware: use steam-devices-udev-rules #363563

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Dec 9, 2024

  • steam-devices-udev-rules: init at 1.0.0.61-unstable-2024-05-22
  • nixos/hardware.steam-hardware: use steam-devices-udev-rules

ValveSoftware maintains an udev rules repo to help downstream distributions.

steam-devices-udev-rules is created from that, and contains only udev rules.

The udev rules contents are the some as steam-unwrapped.

hardware.steam-hardware.enable option is also useful for apps like
cemu and rpcs3, after this, it can be enabled without enabling
nixpkgs.config.allowUnfree and installing steam-unwrapped.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

ValveSoftware maintains an [udev rules repo][1] to help downstream distributions.

`steam-devices-udev-rules` is created from that, and contains only udev rules.

The udev rules contents are the some as `steam-unwrapped`.

`hardware.steam-hardware.enable` option is also useful for apps like
`cemu` and `rpcs3`, after this, it can be enabled without enabling
`nixpkgs.config.allowUnfree` and installing `steam-unwrapped`.

[1]: https://github.com/ValveSoftware/steam-devices
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 10, 2024
@azuwis azuwis requested a review from K900 December 11, 2024 09:57
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 11, 2024
@wolfgangwalther wolfgangwalther merged commit df92923 into NixOS:master Dec 15, 2024
40 of 41 checks passed
@azuwis azuwis deleted the push-owrxuypouwok branch December 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: hardware 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants