-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
earlyoom: Apply security recommendations from package maintainer (First attempt) #363597
Conversation
My pull request may not be the most elegant, but it implements the security restrictions recommended by the package maintainer.
Merged both systemd blocks to one single
Removed Trailing whitespace
Hello. Firstly, welcome to nixpkgs. Your changes aren't indented correctly, if you could address that it'd be great. If you can link the documentation from easyoom which recommends these options that would be helpful for review. |
Hi @06kellyjac, Thank you so much for your suggestions! Could you please let me know what is incorrect or missing to make my commit approvable? Specifically, regarding the comment "Your changes aren't indented correctly." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: j-k <[email protected]>
Unquoted numbers and booleans
The indentation from a previous commit has been corrected.
Removed trailing space
Hi @06kellyjac, I've implemented all your suggestions except for the To be honest, I'm not sure how to squash the commits. If you could assist with that, I’d really appreciate it (I rarely use Git commands). It looks like all the checks have passed successfully so far. :D Thanks! |
My pull request might not be the most elegant solution, but it implements the security restrictions recommended by the package maintainer. I would appreciate any help with verifying and testing the changes. Thank you very much! :D
Source for my changes: https://github.com/rfjakob/earlyoom/blob/master/earlyoom.service.in
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.