-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kryptor: .NET 6 -> 8 #363629
kryptor: .NET 6 -> 8 #363629
Conversation
502f90b
to
bfbb5b8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ofborg build kryptor kryptor.passthru.tests |
bfbb5b8
to
47dcb03
Compare
47dcb03
to
e7b93f4
Compare
#!nix-shell --pure -i bash -p bash nix nix-update git cacert | ||
set -euo pipefail | ||
|
||
nix-update kryptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like, you could use "$UPDATE_NIX_ATTR_PATH"
here, and on the next line.
Some packages even do something like:
attr="${UPDATE_NIX_ATTR_PATH:-kryptor}"
to keep the script working when called directly.
It's only helpful if someone makes an overridden version of the package at another attribute path, so it's up to you whether you think it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's cleaner as it is now, even if it won't work for overridden packages, thanks for the suggestion though.
Bit off topic but are there any plans for passthru.updateScript = nix-update-script { }
supporting dotnet and updating deps.nix
?
It works with for example pnpm packages, where it updates the hash inside pnpmDeps = pnpm.fetchDeps { hash = "..."; ... }
Also currently it's nice that each nuget package from deps.nix
(and soon deps.json
) is a seperate derivation and can be built independently, but regarding to #327064, what do you think about something like nugetDeps = dotnet_sdk.fetchNugetDeps { hash = "..."; ... };
? A similar movement is also happening for rust packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about something like nugetDeps = dotnet_sdk.fetchNugetDeps { hash = "..."; ... };?
The problem is that restore isn't deterministic. There's no lock-file in most packages, and even if there was, the dotnet lockfile mechanism has some problems.
It's a good idea though. Maybe we'll get there eventually.
Successfully created backport PR for |
Tracking: #326335
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.