Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kryptor: .NET 6 -> 8 #363629

Merged
merged 6 commits into from
Dec 10, 2024
Merged

kryptor: .NET 6 -> 8 #363629

merged 6 commits into from
Dec 10, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 9, 2024

Tracking: #326335

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird changed the title kryptor: nixfmt kryptor: .NET 6 -> 8 Dec 9, 2024
@gepbird gepbird mentioned this pull request Dec 9, 2024
17 tasks
@gepbird
Copy link
Contributor Author

gepbird commented Dec 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363629


x86_64-linux

✅ 1 package built:
  • kryptor

@gepbird gepbird requested a review from arthsmn December 9, 2024 16:44
Copy link
Member

@arthsmn arthsmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gepbird gepbird added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 9, 2024
@gepbird
Copy link
Contributor Author

gepbird commented Dec 9, 2024

cc @corngood @emilazy (#358533)

pkgs/by-name/kr/kryptor/update.sh Outdated Show resolved Hide resolved
@getchoo
Copy link
Member

getchoo commented Dec 9, 2024

@ofborg build kryptor kryptor.passthru.tests

@getchoo getchoo removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 9, 2024
#!nix-shell --pure -i bash -p bash nix nix-update git cacert
set -euo pipefail

nix-update kryptor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like, you could use "$UPDATE_NIX_ATTR_PATH" here, and on the next line.

Some packages even do something like:

attr="${UPDATE_NIX_ATTR_PATH:-kryptor}"

to keep the script working when called directly.

It's only helpful if someone makes an overridden version of the package at another attribute path, so it's up to you whether you think it's worth it.

Copy link
Contributor Author

@gepbird gepbird Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's cleaner as it is now, even if it won't work for overridden packages, thanks for the suggestion though.

Bit off topic but are there any plans for passthru.updateScript = nix-update-script { } supporting dotnet and updating deps.nix?
It works with for example pnpm packages, where it updates the hash inside pnpmDeps = pnpm.fetchDeps { hash = "..."; ... }

Also currently it's nice that each nuget package from deps.nix (and soon deps.json) is a seperate derivation and can be built independently, but regarding to #327064, what do you think about something like nugetDeps = dotnet_sdk.fetchNugetDeps { hash = "..."; ... };? A similar movement is also happening for rust packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about something like nugetDeps = dotnet_sdk.fetchNugetDeps { hash = "..."; ... };?

The problem is that restore isn't deterministic. There's no lock-file in most packages, and even if there was, the dotnet lockfile mechanism has some problems.

It's a good idea though. Maybe we'll get there eventually.

@getchoo getchoo added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 10, 2024
@gepbird gepbird requested a review from arthsmn December 10, 2024 07:10
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Dec 10, 2024
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Dec 10, 2024
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 10, 2024
@corngood corngood merged commit 2eccf31 into NixOS:master Dec 10, 2024
23 of 24 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 10, 2024

Successfully created backport PR for release-24.11:

@gepbird gepbird deleted the kryptor-dotnet-8 branch December 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people backport release-24.11 Backport PR automatically ofborg-internal-error Ofborg encountered an error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants