Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protonvpn-gui: 4.8.0 -> 4.8.1 #363658

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

Steinhagen
Copy link
Contributor

@Steinhagen Steinhagen commented Dec 9, 2024

Update the package to the latest version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Steinhagen Steinhagen requested review from Atemu and SebTM December 9, 2024 17:49
@Atemu
Copy link
Member

Atemu commented Dec 9, 2024

You forgot the maintainer addition part. Please do so as a separate commit.

Update the package to the latest version.
@Steinhagen Steinhagen force-pushed the protonvpn-update-4-8-1 branch from 5a65504 to 0d3597f Compare December 9, 2024 21:30
@Steinhagen
Copy link
Contributor Author

I will create a separate PR for the maintainer part. For now I've updated all messages to reflect only the version bump.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
@getchoo
Copy link
Member

getchoo commented Dec 9, 2024

@ofborg build protonvpn-gui protonvpn-gui.passthru.tests

@Atemu
Copy link
Member

Atemu commented Dec 9, 2024

No need for a separate PR, just push the commit here; it's fine.

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 9, 2024
@Aleksanaa Aleksanaa merged commit 378ea51 into NixOS:master Dec 15, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants