Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config-store: init at 1.0.0 #363701

Merged
merged 2 commits into from
Dec 11, 2024
Merged

config-store: init at 1.0.0 #363701

merged 2 commits into from
Dec 11, 2024

Conversation

DOD-101
Copy link
Contributor

@DOD-101 DOD-101 commented Dec 9, 2024

Add config store

Description: A simple key-value store designed to be used from shell scripts written in rust.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

getchoo
getchoo reviewed Dec 9, 2024
View reviewed changes
pkgs/by-name/co/config-store/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/config-store/package.nix Outdated Show resolved Hide resolved
getchoo
getchoo requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

pkgs/by-name/co/config-store/package.nix Outdated Show resolved Hide resolved
@DOD-101 DOD-101 requested a review from getchoo December 10, 2024 06:35
getchoo
getchoo approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Feel free to ping me in a couple days if there are no other reviews

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 11, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 11, 2024
@getchoo getchoo merged commit 83b3052 into NixOS:master Dec 11, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOD-101 @Aleksanaa @getchoo