Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobilizon: 4.1.0 -> 5.1.0 #363711

Merged
merged 1 commit into from
Dec 11, 2024
Merged

mobilizon: 4.1.0 -> 5.1.0 #363711

merged 1 commit into from
Dec 11, 2024

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Dec 9, 2024

Changelogs:

Notes:

  • This PR has been successfully deployed on https://rheinneckar.events
  • The update script is broken, and in the current state can never have worked in the first place. Besides mistakingly using writeShellScriptBin instead of writeShellScript, it doesn't even update anything. For this reason, there also was no PR by r-ryantm even though 5.0 came out two months ago. I will not fix it in this PR.
  • There were no dependency updates in either release, so mix.nix (and the dependency overrides) remaing unchanged.
  • Despite the major version bump, 5.1 (and 5.0) do not have any breaking changes. The major version bump only reflects that this was the first release by the new developers at Kaihuri. It is thus acceptable to backport 5.1.0 to NixOS 24.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erictapen
Copy link
Member

Thanks for taking a look at this. I didn't really have the time to update the definition in Nixpkgs, though I follow development and maintain a package definition off-tree.

I'm fine with backporting this to 24.11, even though does 5.1.0 includes a few new features.

The update script was supposed to be run with nix run .#mobilizon.updateScript, but I guess you invoked it in a more standard compliant way? I'd be happy to review a PR to make it more compliant (and complete, it only updates mix dependencies currently).

@erictapen erictapen added the backport release-24.11 Backport PR automatically label Dec 11, 2024
@erictapen erictapen merged commit 6af66e9 into NixOS:master Dec 11, 2024
99 of 100 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 11, 2024

Successfully created backport PR for release-24.11:

@niklaskorz
Copy link
Contributor Author

Thanks for taking a look at this. I didn't really have the time to update the definition in Nixpkgs, though I follow development and maintain a package definition off-tree.

I'm fine with backporting this to 24.11, even though does 5.1.0 includes a few new features.

The update script was supposed to be run with nix run .#mobilizon.updateScript, but I guess you invoked it in a more standard compliant way? I'd be happy to review a PR to make it more compliant (and complete, it only updates mix dependencies currently).

Thank you! I can look into providing a complete update script.

@niklaskorz niklaskorz deleted the update-mobilizon branch December 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants