Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ankama-launcher: 3.12.26 -> 3.12.27 #363713

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Harbiinger
Copy link

Things done

cc @GaetanLepage

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Note: I have removed the text about the wine error since it was only occuring with Dofus 2 which is not available anymore.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
Comment on lines -51 to -53

If you encounter a `wine` error while running *Dofus*, delete or rename the `cinematics/` directory:
- Go to the directory where you installed the game and run: `mv content/gfx/cinematics content/gfx/cinematics_DISABLE`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug with the content folder is gone ?

Copy link
Author

@Harbiinger Harbiinger Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only with Dofus 2. I've put a note at the end of the pr's description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. Thanks !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363713


x86_64-linux

✅ 1 package built:
  • ankama-launcher

aarch64-linux


x86_64-darwin


aarch64-darwin

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@GaetanLepage GaetanLepage merged commit 314edfd into NixOS:master Dec 9, 2024
19 of 20 checks passed
@GaetanLepage GaetanLepage added the backport release-24.11 Backport PR automatically label Dec 9, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 9, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 9, 2024

Git push to origin failed for release-24.11 with exitcode 1

@SigmaSquadron SigmaSquadron removed their request for review December 9, 2024 22:19
@Harbiinger Harbiinger deleted the update-3.12.27 branch December 9, 2024 22:20
@nezia1
Copy link
Contributor

nezia1 commented Dec 10, 2024

Hey, I've ran into an issue with your package (I actually ran in the same issue myself trying to package it.). It seems that whenever the launcher self updates, it completely stops working, making the launcher unusable despite having deleted $XDG_CONFIG_HOME/zaap. These are the logs I get:

12/10/2024, 8:53:56 AM.5 - info: [AUTO_UPDATER] Has checked for updates true
12/10/2024, 8:53:56 AM.5 - info: [AUTO_UPDATER] An update is available
12/10/2024, 8:53:56 AM.9 - error: [1015 AUTO_UPDATER] error, Error: APPIMAGE env is not defined
    at Object.t.newError (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:54148)
    at Object.task (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:184:188162)
    at d.executeDownload (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:80166) Error: APPIMAGE env is not defined
    at Object.t.newError (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:54148)
    at Object.task (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:184:188162)
    at d.executeDownload (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:80166)
12/10/2024, 8:53:56 AM.9 - error: [MAIN] Autoupdater failed
12/10/2024, 8:53:56 AM.9 - info: [MAIN] primarySetups
12/10/2024, 8:53:56 AM.11 - error: [1074 MAIN] A fatal error occurred (unhandled rejection) Error: APPIMAGE env is not defined
    at Object.t.newError (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:54148)
    at Object.task (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:184:188162)
    at d.executeDownload (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:80166)
(node:171092) UnhandledPromiseRejectionWarning: Error: APPIMAGE env is not defined
    at Object.t.newError (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:54148)
    at Object.task (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:184:188162)
    at d.executeDownload (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:80166)
(Use `zaap --trace-warnings ...` to show where the warning was created)
(node:171092) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
12/10/2024, 8:53:56 AM.22 - error: [1083 SENTRY] Sending error data to sentry, event id: bd182904b5334d68a6837c7a936e90ce
12/10/2024, 8:53:56 AM.30 - info: [I18next] Successfully initialized
12/10/2024, 8:53:56 AM.30 - info: [UNIVERSE] setup
12/10/2024, 8:53:56 AM.122 - info: [UNIVERSE] Downloaded universes config
12/10/2024, 8:53:57 AM.374 - info: No settings for service games in universe /home/nezia/.config/zaap/universe/Krosmoz
12/10/2024, 8:53:57 AM.382 - info: [REGISTRY] setup
12/10/2024, 8:53:57 AM.384 - debug: [REGISTRY] listening repository update
12/10/2024, 8:53:57 AM.386 - info: No settings for service stream in universe /home/nezia/.config/zaap/universe/Krosmoz
12/10/2024, 8:53:57 AM.386 - info: No settings for service webtoon in universe /home/nezia/.config/zaap/universe/Krosmoz
12/10/2024, 8:53:57 AM.386 - info: No settings for service shop in universe /home/nezia/.config/zaap/universe/Krosmoz
12/10/2024, 8:53:57 AM.386 - warn: [REGISTRY] Failed to load local repository file: Error: ENOENT: no such file or directory, open '/home/nezia/.config/zaap/repositories/repositories.json'
12/10/2024, 8:53:57 AM.391 - info: No settings for service video in universe /home/nezia/.config/zaap/universe/Krosmoz
12/10/2024, 8:53:57 AM.641 - debug: [REGISTRY] update
12/10/2024, 8:53:57 AM.644 - warn: [UNIVERSE] Repository was set but could not fetch initial games list TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'ClientRequest'
    |     property 'res' -> object with constructor 'IncomingMessage'
    --- property 'req' closes the circle
    at JSON.stringify (<anonymous>)
    at e.exports.saveRepositoryListFile (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:459:162939)
    at e.exports.update (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:459:160346)
    at /nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:459:163039
12/10/2024, 8:53:57 AM.684 - debug: [REGISTRY] update
12/10/2024, 8:53:57 AM.685 - debug: [REGISTRY] Parse repository Data
12/10/2024, 8:53:57 AM.690 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.690 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.690 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.691 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.691 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.691 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.691 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.692 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.692 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.702 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.704 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.706 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.707 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.707 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.707 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.707 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.707 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.708 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.728 - warn: [INFORMATION] error while checking dataDir
12/10/2024, 8:53:57 AM.729 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:57 AM.729 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:57 AM.917 - info: No settings for service webtoon in universe /home/nezia/.config/zaap/universe/Allskreen
12/10/2024, 8:53:57 AM.918 - info: No settings for service shop in universe /home/nezia/.config/zaap/universe/Allskreen
12/10/2024, 8:53:58 AM.177 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.215 - debug: [GAME_CONFIG] New configuration dofus dofus3
12/10/2024, 8:53:58 AM.252 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.252 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.253 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.255 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.255 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.271 - debug: [GAME_CONFIG] New configuration retro main
12/10/2024, 8:53:58 AM.296 - debug: [GAME_CONFIG] New configuration dofus main
12/10/2024, 8:53:58 AM.322 - debug: [GAME_CONFIG] New configuration wakfu main
12/10/2024, 8:53:58 AM.339 - debug: [GAME_CONFIG] New configuration dofus beta
12/10/2024, 8:53:58 AM.359 - debug: [GAME_CONFIG] New configuration wakfu beta
12/10/2024, 8:53:58 AM.466 - warn: [ZB-514] setConfiguration (load)
12/10/2024, 8:53:58 AM.478 - debug: [GAME_CONFIG] New configuration retro beta
12/10/2024, 8:53:58 AM.646 - info: [REGISTRY] setup
12/10/2024, 8:53:58 AM.647 - debug: [REGISTRY] listening repository update
12/10/2024, 8:53:58 AM.648 - debug: [REGISTRY] Parse repository Data
12/10/2024, 8:53:58 AM.652 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.653 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.654 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:58 AM.654 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:58 AM.663 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.663 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.666 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:58 AM.666 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:58 AM.669 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.671 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:53:58 AM.675 - debug: [1121 INFORMATION] Failed to load information data (information.json)
12/10/2024, 8:53:58 AM.676 - debug: [1121 INFORMATION] Failed to load game file release.json
12/10/2024, 8:54:05 AM.521 - info: [UNIVERSE] Register universe Krosmoz
12/10/2024, 8:54:05 AM.521 - info: [UNIVERSE] Register universe Allskreen
12/10/2024, 8:54:05 AM.522 - info: [UNIVERSE] krosmoz selected
12/10/2024, 8:54:05 AM.552 - error: [AppError] 
{
  "code": 8001,
  "message": "No API KEY found on machine",
  "displayMessageOnFront": true,
  "complement": {},
  "name": "Error",
  "stack": "Error: No API KEY found on machine\n    at u.authenticateFromStoredApiKey (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:64859)\n    at u.setup (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:1:57303)\n    at i.primarySetups (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:99315)\n    at i.bootstrapOnce (/nix/store/0zvga75q8r15dydn77fvg291f63aij9x-ankama-launcher-3.12.24-extracted/resources/app.asar/main.js:71:98545)"
}
12/10/2024, 8:54:05 AM.559 - info: [SHOP] setup
12/10/2024, 8:54:05 AM.562 - info: [PIP] setup
12/10/2024, 8:54:05 AM.563 - info: [OVERLAY] setup
12/10/2024, 8:54:05 AM.565 - info: [AUTO_LAUNCH] setting to false
12/10/2024, 8:54:05 AM.566 - info: [NEWS] setup
12/10/2024, 8:54:05 AM.567 - info: [CHANGELOGS] setup
12/10/2024, 8:54:05 AM.567 - info: [TERMS] setup
12/10/2024, 8:54:05 AM.575 - debug: [REGISTRY] update
12/10/2024, 8:54:05 AM.590 - debug: [REGISTRY] Parse repository Data

As we can see above, it looks like it's related to the APPIMAGE env not being defined somehow, and some of the program's logic relying on that to self-update. There's also this API_KEY issue, which I'm unsure if it's even related.

@GaetanLepage
Copy link
Contributor

Hey, I've ran into an issue with your package (I actually ran in the same issue myself trying to package it.). It seems that whenever the launcher self updates, it completely stops working, making the launcher unusable despite having deleted $XDG_CONFIG_HOME/zaap. These are the logs I get:

I tried the latest version from the nixpkgs master branch and it seems to work fine.
Though, it has not yet landed in nixos-unstable.
Maybe, try again with the new version when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants