-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syspower: init at 0-unstable-2024-12-12 #363716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
598f3c4
to
0d0dbab
Compare
0d0dbab
to
62667f9
Compare
Thank you for your help here! This is my first time adding a package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help here! This is my first time adding a package.
Glad I could help :)
62667f9
to
8d165bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ping me in a couple days if no other reviews come along
There's a new revision of this package that fixes a very important bug. Should I update this pull request to init at this newer version? |
Yeah feel free. It'd be much better for this package to land with that fix |
This fixes a crucial bug relating to usage with nixos
cdfa460
to
17ffb60
Compare
@ofborg build syspower syspower.passthru.tests |
Adds Syspower, a simple power menu/shutdown screen for Hyprland.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.