Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syspower: init at 0-unstable-2024-12-12 #363716

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

justDeeevin
Copy link
Contributor

Adds Syspower, a simple power menu/shutdown screen for Hyprland.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/by-name/sy/syspower/package.nix Show resolved Hide resolved
@justDeeevin
Copy link
Contributor Author

Thank you for your help here! This is my first time adding a package.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help here! This is my first time adding a package.

Glad I could help :)

pkgs/by-name/sy/syspower/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ping me in a couple days if no other reviews come along

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 11, 2024
@justDeeevin
Copy link
Contributor Author

There's a new revision of this package that fixes a very important bug. Should I update this pull request to init at this newer version?

@getchoo
Copy link
Member

getchoo commented Dec 11, 2024

Yeah feel free. It'd be much better for this package to land with that fix

This fixes a crucial bug relating to usage with nixos
@justDeeevin justDeeevin changed the title syspower: init at 0-unstable-2024-12-10 syspower: init at 0-unstable-2024-12-12 Dec 11, 2024
@getchoo getchoo removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
@getchoo
Copy link
Member

getchoo commented Dec 12, 2024

@ofborg build syspower syspower.passthru.tests

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
@getchoo getchoo merged commit c630658 into NixOS:master Dec 12, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants