Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitty: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12; python3Packages.django-q: drop #363754

Merged
merged 4 commits into from
Dec 16, 2024
Merged

python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitty: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12; python3Packages.django-q: drop #363754

merged 4 commits into from
Dec 16, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 9, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review December 9, 2024 22:51
@nix-owners nix-owners bot requested a review from natsukium December 9, 2024 22:52
getchoo
getchoo reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ways to avoid rec/plain let ...; in. Rest of the diff LGTM

pkgs/servers/mail/mailman/python.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/django-q2/default.nix Outdated Show resolved Hide resolved
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 11, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 11, 2024
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 12, 2024
Merged
13 tasks
@SuperSandro2000 SuperSandro2000 changed the title python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitts: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12 python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitty: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12 Dec 13, 2024
@SuperSandro2000 SuperSandro2000 changed the title python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitty: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12 python312Packages.django-q2: init at 1.7.4; mailmanPackages.hyperkitty: 1.3.9 -> 1.3.12; mailmanPackages: use python 3.12; python3Packages.django-q: drop Dec 13, 2024
@SuperSandro2000
Copy link
Member Author

Also took the opportunity to outright drop django-q

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@SuperSandro2000
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 363754

x86_64-linux

✅ 10 packages built:
  • mailman
  • mailman-hyperkitty
  • mailman-hyperkitty.dist
  • mailman-web
  • mailman-web.dist
  • mailman.dist
  • python311Packages.django-q2
  • python311Packages.django-q2.dist
  • python312Packages.django-q2
  • python312Packages.django-q2.dist

@SuperSandro2000 SuperSandro2000 merged commit 1c8a5ba into NixOS:master Dec 16, 2024
49 of 50 checks passed
@SuperSandro2000 SuperSandro2000 deleted the hyperkitty branch December 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@natsukium natsukium Awaiting requested review from natsukium

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuperSandro2000 @dotlambda @getchoo @wegank