Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove titanium, titaniumenv, and titanium-alloy #363755

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

DimitarNestorov
Copy link
Member

The Titanium SDKs, env, and npm packages seem to be outdated:

Things done

Removed titanium, titaniumenv, and titanium-alloy

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

aarch64-darwin

✅ 1 package built:

  • nixpkgs-manual

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 6.topic: nodejs labels Dec 9, 2024
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 10, 2024
@DimitarNestorov DimitarNestorov force-pushed the remove-titanium branch 2 times, most recently from 7c5a5b3 to 441397e Compare December 11, 2024 19:32
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 12, 2024
@fricklerhandwerk fricklerhandwerk merged commit 10a75ab into NixOS:master Jan 2, 2025
25 of 26 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fricklerhandwerk @getchoo Please be more attentive to commit history. This PR introduced the concept of Nixpkgs release notes under a commit titled "doc: titanium tombstone" without any further context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sorry, missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants