Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq: making sure coq master and 9.0 compile #363757

Closed
wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@CohenCyril CohenCyril marked this pull request as draft December 9, 2024 23:14
@github-actions github-actions bot added the 6.topic: coq "A formal proof management system" label Dec 9, 2024
@CohenCyril
Copy link
Contributor Author

For now this errors with the following message when running ./result/bin/coqtop 😕

Welcome to Coq 9.0+alpha
Error:
Findlib error: zarith not found in:
/nix/store/c2hwnp5ryalzz1rwldp7a87lzxaq1329-coq-dev/lib/coq/../coq-core/..
/nix/store/c2hwnp5ryalzz1rwldp7a87lzxaq1329-coq-dev/lib/coq/user-contrib/Ltac2
/nix/store/c2hwnp5ryalzz1rwldp7a87lzxaq1329-coq-dev/lib/coq/user-contrib/Ltac2/Compat
/nix/store/bj6kj93sbg5j0vgv5yrxfcq91fj9pqfi-ocaml4.14.2-findlib-1.9.8/lib/ocaml/4.14.2/site-lib
required by `coq-core.interp'

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 9, 2024
@vbgl
Copy link
Contributor

vbgl commented Dec 11, 2024

Thanks Cyril for working on this! Regarding the coqtop failure, did you try wrapping the binary (like, e.g., rtop):

postInstall = ''
wrapProgram $out/bin/rtop \
--prefix PATH : "${utop}/bin" \
--prefix CAML_LD_LIBRARY_PATH : "$CAML_LD_LIBRARY_PATH" \
--prefix OCAMLPATH : "$OCAMLPATH:$OCAMLFIND_DESTDIR"
'';

@vbgl vbgl added the backport release-24.11 Backport PR automatically label Dec 12, 2024
@vbgl
Copy link
Contributor

vbgl commented Dec 16, 2024

This was wrong advice. Sorry about that.

I guess this PR can be closed, thanks to the nice work by Pierre.

@CohenCyril
Copy link
Contributor Author

Subsumed by #364617

@CohenCyril CohenCyril closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: coq "A formal proof management system" 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants