Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] Treewide Nix reformat pass 1 [skip treewide] #364000

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

infinisil
Copy link
Member

This is the staging-next version of #322537, see its description for more info. These PRs will be merged together to avoid backporting problems.

Verification

The reformatting commit is fully auto-generated by the code in https://github.com/infinisil/treewide-nixpkgs-reformat-script, see the commit message on how to do a complete verification.


This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.

Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.

A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.

This commit was automatically created and can be verified using

    nix-build https://github.com/infinisil/treewide-nixpkgs-reformat-script/archive/a08b3a4d199c6124ac5b36a889d9099b4383463f.tar.gz \
      --argstr baseRev 78e9caf
    result/bin/apply-formatting $NIXPKGS_PATH
@infinisil infinisil force-pushed the treewide-format-staging-next branch from 5455c06 to 84d4f87 Compare December 10, 2024 19:24
@infinisil infinisil marked this pull request as ready for review December 10, 2024 19:42
@infinisil infinisil merged commit 1f6571c into NixOS:staging-next Dec 10, 2024
22 of 23 checks passed
@infinisil infinisil deleted the treewide-format-staging-next branch December 10, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant