Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.avante-nvim: move out to separate directory #364001

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

PerchunPak
Copy link
Member

Similarly to vimPlugins.blink-cmp. This is done to remove manual intervention in vimPlugins update process.

If we do that [vim plugin updates] so often, shouldn't we automate it?

Ideally, but there are still issues with avante needing manual updates atm. Unless we pull it back out like blink-cmp or something.

Originally posted by @khaneliman in #363741 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364001


x86_64-linux

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

Similarly to `vimPlugins.blink-cmp`. This is done to remove manual
intervention in vimPlugins update process.
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested updater locally and works. Thanks for doing this!

@khaneliman khaneliman merged commit b32a094 into NixOS:master Dec 10, 2024
18 of 19 checks passed
@PerchunPak PerchunPak deleted the avante branch December 10, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants