anki: use fetchCargoVendor #364037
anki: use fetchCargoVendor #364037
Conversation
|
NixOSInfra
added
the
12. first-time contribution
| }; | ||
| cargoDeps = rustPlatform.fetchCargoVendor { | ||
| inherit pname version src; | ||
| hash = "sha256-4V75+jS250XfUH6B4VBxtL2t308nyKzhDoq86kq6rp4="; | ||
| }; |
There was a problem hiding this comment.
my understanding from looking at the docs last week was that this could be written as follow:
useFetchCargoVendor = true;
cargoHash = "sha256-4V75+jS250XfUH6B4VBxtL2t308nyKzhDoq86kq6rp4";
I don't have a hard preference, either get rid of the lock file which is a pain to update, if someone knows if there's a canonical/preferred way please chime in.
There was a problem hiding this comment.
I suppose this has the advantage that you don't need to copy the hash in sync-server, you can just reuse cargoDeps.
There was a problem hiding this comment.
Is there something that'd make cargoHash impossible to inherited just like cagoDeps?
But anyway, as said above, I'm not picky - this is just curiosity asking.
There was a problem hiding this comment.
Yes, that would also work.
wegank
added
12.approvals: 1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.