Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: disable flaky darwin test and enable some tests on x64 darwin #364055

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 10, 2024

test fails on darwin sometimes but will pass eventually

https://hydra.nixos.org/build/281912463/nixlog/234

enable x64 darwin tests that were disabled due to using an sdk < 10.15 now that it uses sdk 11

remove conditionally disabled tests which are already disabled by default

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 10, 2024
@alyssais
Copy link
Member

Reported upstream?

@paparodeo paparodeo closed this Dec 11, 2024
@paparodeo
Copy link
Contributor Author

Reported upstream?

quite a number of tests seem quite unreliable and there are something like 50 tests disabled with a comment.

    # Sometimes: timeout (no output), failed uv_listen. Someone
          # should report these failures to libuv team. There tests should
          # be much more robust.

I don't want to volunteer to be the libuv maintainer at this time but perhaps will circle back at some point.

@paparodeo paparodeo deleted the libuv-disable-spurious branch December 11, 2024 20:08
@paparodeo
Copy link
Contributor Author

libuv/libuv#4650

@juanarbol
Copy link

Intended to be fixed in libuv/libuv#4652, sorry for the inconveniences.

@paparodeo paparodeo restored the libuv-disable-spurious branch December 15, 2024 17:33
@paparodeo
Copy link
Contributor Author

should disable test in the meantime -- while the failure rate on my machine is low it seems to fail regularly on hydra.

@paparodeo paparodeo reopened this Dec 15, 2024
@paparodeo paparodeo force-pushed the libuv-disable-spurious branch from 47cde7b to 07fc8e3 Compare December 15, 2024 17:37
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 15, 2024
@alyssais
Copy link
Member

Would be better to backport the patch — it'll be noticed when updating, whereas a manually disabled test is unlikely to be.

@paparodeo
Copy link
Contributor Author

paparodeo commented Dec 15, 2024

Would be better to backport the patch — it'll be noticed when updating, whereas a manually disabled test is unlikely to be.

it will prevent the auto-updater from updating the package as the patch will conflict

[edit] tho could conditionally disable with versionOlder

test fails on darwin sometimes
@paparodeo paparodeo force-pushed the libuv-disable-spurious branch from 07fc8e3 to 1347cc7 Compare December 16, 2024 00:07
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin ofborg-internal-error Ofborg encountered an error labels Dec 16, 2024
x64 darwin now uses sdk 11 thus can enable tests requiring an sdk >
10.12
remove conditionally disabled tests if they are already disabled by
default.
@paparodeo paparodeo changed the title libuv: disable flaky darwin test libuv: disable flaky darwin test and enable some tests on x64 darwin Dec 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Dec 16, 2024
@alyssais alyssais merged commit 69dd998 into NixOS:staging Dec 18, 2024
58 of 59 checks passed
@alyssais
Copy link
Member

Thanks a lot for the cleanup!

@paparodeo paparodeo deleted the libuv-disable-spurious branch December 18, 2024 14:49
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants