-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libuv: disable flaky darwin test and enable some tests on x64 darwin #364055
Conversation
Reported upstream? |
quite a number of tests seem quite unreliable and there are something like 50 tests disabled with a comment.
I don't want to volunteer to be the libuv maintainer at this time but perhaps will circle back at some point. |
Intended to be fixed in libuv/libuv#4652, sorry for the inconveniences. |
should disable test in the meantime -- while the failure rate on my machine is low it seems to fail regularly on hydra. |
47cde7b
to
07fc8e3
Compare
Would be better to backport the patch — it'll be noticed when updating, whereas a manually disabled test is unlikely to be. |
it will prevent the auto-updater from updating the package as the patch will conflict [edit] tho could conditionally disable with |
test fails on darwin sometimes
07fc8e3
to
1347cc7
Compare
x64 darwin now uses sdk 11 thus can enable tests requiring an sdk > 10.12
remove conditionally disabled tests if they are already disabled by default.
Thanks a lot for the cleanup! |
test fails on darwin sometimes but will pass eventually
https://hydra.nixos.org/build/281912463/nixlog/234
enable x64 darwin tests that were disabled due to using an sdk < 10.15 now that it uses sdk 11
remove conditionally disabled tests which are already disabled by default
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.