Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: 7.35.0 -> 7.36.0; signal-desktop(darwin): 7.35.0 -> 7.36.0; signal-desktop(aarch64-linux): 7.34.0 -> 7.36.0 #364691

Merged
merged 3 commits into from
Dec 23, 2024
Merged

signal-desktop: 7.35.0 -> 7.36.0; signal-desktop(darwin): 7.35.0 -> 7.36.0; signal-desktop(aarch64-linux): 7.34.0 -> 7.36.0 #364691

merged 3 commits into from
Dec 23, 2024

Conversation

Gliczy
Copy link
Member

@Gliczy Gliczy commented Dec 12, 2024 •
edited by GaetanLepage
Loading

https://github.com/signalapp/Signal-Desktop/releases/tag/v7.36.0
signalapp/Signal-Desktop@v7.35.0...v7.36.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gliczy
Copy link
Member Author

Gliczy commented Dec 12, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364691

x86_64-linux

✅ 1 package built:
  • signal-desktop

aarch64-linux

✅ 1 package built:
  • signal-desktop

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 13, 2024
@Gliczy Gliczy requested a review from teutat3s December 14, 2024 13:15
@Gliczy Gliczy changed the title signal-desktop: 7.35.0 -> 7.36.0; signal-desktop(darwin): 7.35.0 -> 7.36.0; signal-desktop(aarch64-linux): 7.34.0 -> 7.35.1 signal-desktop: 7.35.0 -> 7.36.0; signal-desktop(darwin): 7.35.0 -> 7.36.0; signal-desktop(aarch64-linux): 7.34.0 -> 7.36.0 Dec 14, 2024
obadz
obadz approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@obadz obadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry picked locally and it works fine for me (on Linux)

@obadz obadz mentioned this pull request Dec 16, 2024
Open
@Gliczy Gliczy added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 16, 2024
@teutat3s teutat3s added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 16, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 16, 2024
@teutat3s teutat3s added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 17, 2024
@teutat3s teutat3s requested review from Mic92, urandom2 and bkchr December 17, 2024 20:31
@teutat3s teutat3s requested review from emilazy and equirosa December 17, 2024 20:31
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Dec 18, 2024
@teutat3s
Copy link
Member

@ofborg build signal-desktop
@ofborg test signal-desktop

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364691

x86_64-linux

✅ 1 package built:
  • signal-desktop

aarch64-linux

✅ 1 package built:
  • signal-desktop

x86_64-darwin

✅ 1 package built:
  • signal-desktop

aarch64-darwin

✅ 1 package built:
  • signal-desktop

@GaetanLepage GaetanLepage merged commit 5841ea7 into NixOS:master Dec 23, 2024
92 of 96 checks passed
@nix-backports
Copy link

nix-backports bot commented Dec 23, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-364691-to-release-24.05 origin/release-24.05
cd .worktree/backport-364691-to-release-24.05
git switch --create backport-364691-to-release-24.05
git cherry-pick -x 60bd0eab7cd050bbfe0c91f24ccef8a93b110a7c 25fc067aff095e97d1edf0a1c37f4c38226a1fbb 4c24a07cafd18333dbf1d7fa97e60b37e1ec0829

@nix-backports
Copy link

nix-backports bot commented Dec 23, 2024

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Dec 23, 2024
Merged
1 task
@teutat3s teutat3s mentioned this pull request Dec 29, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@teutat3s teutat3s teutat3s approved these changes

@obadz obadz obadz approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@urandom2 urandom2 Awaiting requested review from urandom2

@bkchr bkchr Awaiting requested review from bkchr

@emilazy emilazy Awaiting requested review from emilazy

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gliczy @teutat3s @GaetanLepage @obadz @wegank