Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsume: install correct Zsh autocompletion #364989

Closed
wants to merge 2 commits into from

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Dec 13, 2024

Fixes #364985

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Completion now works out of the box:

$ awsume #<Tab>
default             production     staging             internal
$ cat /nix/store/140zmknj3in2vp47cbcjp95irdpfpzhj-awsume-4.5.5/share/zsh/site-functions/_awsume
#compdef awsume
_arguments "*: :($(/nix/store/140zmknj3in2vp47cbcjp95irdpfpzhj-awsume-4.5.5/bin/awsume-autocomplete))"

Add a 👍 reaction to pull requests you find important.

@antoineco
Copy link
Contributor Author

I think it would be valuable to backport this to nixos-24.11 and nixos-24.05 since both are affected.

@antoineco
Copy link
Contributor Author

@surfaceflinger apologies for the direct mention; since you reviewed #364972 I figured you might be in a good position to look into this.

Copy link
Member

@surfaceflinger surfaceflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and I can tab-complete profile names!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@antoineco antoineco closed this Jan 12, 2025
@antoineco antoineco reopened this Jan 12, 2025
@antoineco
Copy link
Contributor Author

Ofborg is stuck so the PR is unlikely to get noticed. Closing.

@antoineco antoineco closed this Jan 12, 2025
@antoineco antoineco deleted the awsume-zsh-compl branch January 12, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awsume creates an invalid Zsh completion script
3 participants