Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lockbook-desktop: init at 0.9.15 #365059

Merged
merged 1 commit into from
Jan 4, 2025
Merged

lockbook-desktop: init at 0.9.15 #365059

merged 1 commit into from
Jan 4, 2025

Conversation

Parth
Copy link
Member

@Parth Parth commented Dec 14, 2024 •
edited
Loading

👋 as mentioned in #358794 Lockbook is a secure note taking app. This pull request packages our desktop app!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 14, 2024
@Parth Parth mentioned this pull request Dec 14, 2024
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 14, 2024
@Parth
Copy link
Member Author

Parth commented Dec 16, 2024

👋 @pluiedev, @donovanglover, @Aleksanaa. Thanks for taking the time to review our CLI (#358794), would love a review for our desktop app here as well!

pluiedev
pluiedev suggested changes Dec 16, 2024
View reviewed changes
pkgs/by-name/lo/lockbook-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/lockbook-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/lockbook-desktop/package.nix Outdated Show resolved Hide resolved
@Parth Parth requested a review from pluiedev December 19, 2024 23:48
pluiedev
pluiedev approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for some minor things

pkgs/by-name/lo/lockbook-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/lockbook-desktop/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@Parth
Copy link
Member Author

Parth commented Dec 26, 2024

Thanks for the approval @pluiedev. Do you know what next steps are here?

@pluiedev
Copy link
Contributor

Wait for a committer

@pluiedev pluiedev added the awaiting_merger (old Marvin label, do not use) label Dec 26, 2024
@Parth
Copy link
Member Author

Parth commented Dec 28, 2024

👋 @Aleksanaa, if you have some time could you see if we can merge this?

@Parth
Copy link
Member Author

Parth commented Jan 3, 2025

@Defelo I see you've merged some rust packages in recently, could you take a look at this one?

@Defelo
Copy link
Member

Defelo commented Jan 3, 2025

@Parth Unfortunately I don't have merge privileges, sorry. However I noticed that the last two review comments (tag instead of rev in fetchFromGitHub and release/tag specific changelog) have not been addressed yet, so I would recommend taking a look at those in the meantime. If you need another approval, please feel free to ping me again.

@wolfgangwalther
Copy link
Contributor

If I could edit this PR, I would commit the suggestions and merge. But I can't, editing is not allowed for maintainers. Thus - I don't.

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365059

x86_64-linux

✅ 1 package built:
  • lockbook-desktop

@wolfgangwalther wolfgangwalther merged commit 14c58c5 into NixOS:master Jan 4, 2025
22 checks passed
@Parth Parth added the backport release-24.11 Backport PR automatically label Jan 4, 2025
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 4, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 4, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@pluiedev pluiedev pluiedev approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person awaiting_merger (old Marvin label, do not use) backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Parth @pluiedev @Defelo @wolfgangwalther @wegank