duckstation: 0.1-6759 -> 0.1-7465, build with clang #365429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this is the last commit with the previous GPL license
Fails to build with gcc: duckstation> In function 'void* memcpy(void*, const void*, size_t)', duckstation> inlined from 'FileSystem::AtomicRenamedFile FileSystem::CreateAtomicRenamedFile(std::string, const char*, Error*)' at /build/source/src/common/file_system.cpp:1213:16: duckstation> /nix/store/wlavaybjbzgllhq11lib6qgr7rm8imgp-glibc-2.39-52-dev/include/bits/string_fortified.h:29:33: warning: 'void* __builtin___memcpy_chk(void*, const void*, long unsigned int, long unsigned int)' accessing 9223372036854775801 or more bytes at offsets 0 and 0 overlaps 9223372036854775795 bytes at offset 6 [-Wrestrict] Warnings before building: duckstation> *************** UNSUPPORTED CONFIGURATION *************** duckstation> duckstation> You are not compiling DuckStation with a supported compiler. duckstation> duckstation> It may not even build successfully. duckstation> duckstation> DuckStation only supports the Clang and MSVC compilers. duckstation> duckstation> No support will be provided, continue at your own risk. duckstation> duckstation> *********************************************************
github-actions
bot
added
10.rebuild-darwin: 0
AndersonTorres
approved these changes
Dec 16, 2024
wegank
added
12.approved-by: package-maintainer
AndersonTorres
approved these changes
Dec 17, 2024
|
thiagokokada
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.