-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python313Packages.standard-mailcap: init at 3.13.0 #365443
base: master
Are you sure you want to change the base?
Conversation
77744f9
to
9c163c4
Compare
version = "3.13.0"; | ||
disabled = pythonOlder "3.13"; | ||
src = fetchPypi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "3.13.0"; | |
disabled = pythonOlder "3.13"; | |
src = fetchPypi { | |
version = "3.13.0"; | |
pyproject = true; | |
disabled = pythonOlder "3.13"; | |
src = fetchPypi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject=true is in line 17. Did you miss it or do you want it further at the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the style we usually follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reordered the attributes. Is the order/style (also the pipy vs github stuff) documented somewhere? Or is it just something you learn on the way?
version = "3.13.0"; | ||
disabled = pythonOlder "3.13"; | ||
src = fetchPypi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchFromGitHub
is preferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the github repo has many subfolders with different "dead batteries" in each subfolder. So I would have to pull one subfolder from the github repo. Is that still preferred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this and it looks much more complicated to me.
With fetchPypi I have
src = fetchPypi {
pname = "standard_mailcap";
inherit version;
hash = "sha256-Ge15VdvqzLNei7BbK1RDzlXB+TKoy+elwT1C+dtPSZo=";
};
whereas with fetchFromGitHub I have
src = fetchFromGitHub {
owner = "youknowone";
repo = "python-deadlib";
tag = "v3.13.0";
hash = "sha256-9mtQi5ufxP6xRonTrFC3oWFpWLbJraAmdQYozP3evgc=";
sparseCheckout = [ "mailcap" ];
};
preBuild = "cd mailcap";
Just to be absolutely sure: fetchFromGtHub is still preferred in this situation?
3ab632e
to
4cb1686
Compare
4cb1686
to
98032d8
Compare
@dotlambda I tried to address your comments. Do you mind having another look? |
This is a replacement for the mailcap module from the python standard lib which was removed for python 3.13. This package will be needed for alot to work under python 3.13.
Repo: https://github.com/youknowone/python-deadlib
PyPI: https://pypi.org/project/standard-mailcap/
(There is no proper homepage)
This fixes #362878.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.