python312Packages.markitdown: init at 0-unstable-2024-12-18 #365681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
push-rqopnworpork
branch
from
4b900d4 to
e12a099
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
drupol
force-pushed
the
push-rqopnworpork
branch
from
e12a099 to
4c51d1e
Compare
drupol
commented
Dec 16, 2024
drupol
force-pushed
the
push-rqopnworpork
branch
2 times, most recently
from
3e37130 to
03b15e6
Compare
lucasew
suggested changes
Dec 17, 2024
|
Running nixpkgs-review here: https://github.com/lucasew/nixcfg/actions/runs/12364289266/job/34507250833 |
|
GaetanLepage
requested changes
Dec 17, 2024
ofborg
bot
added
8.has: package (new)
drupol
force-pushed
the
push-rqopnworpork
branch
from
03b15e6 to
35f19e8
Compare
|
|
IMO the things left to be done are
|
It is already in there
I couldn't get cobble, precisely and funk tests running. Help might be needed, I tested edit: I just found out a way to get them running! |
drupol
force-pushed
the
push-rqopnworpork
branch
from
35f19e8 to
5d5bd00
Compare
|
I'd suggest passing the additional test paths via pytest args |
drupol
force-pushed
the
push-rqopnworpork
branch
from
5d5bd00 to
5210962
Compare
Thank you, this is what I did. I couldn't enable tests everywhere because they are relying on |
|
Running nixpkgs-review here https://github.com/lucasew/nixcfg/actions/runs/12379680406/job/34554367173 |
|
|
Otherwise it seems all OK |
Should I remove it? edit: I removed it now. |
drupol
force-pushed
the
push-rqopnworpork
branch
from
5210962 to
b10a644
Compare
|
Related issue about the nose thing #326513 |
|
Diff-wise LGTM Running final nixpkgs-review on https://github.com/lucasew/nixcfg/actions/runs/12382905002/job/34564584179 |
|
drupol
force-pushed
the
push-rqopnworpork
branch
from
b10a644 to
c359044
Compare
drupol
force-pushed
the
push-rqopnworpork
branch
from
c359044 to
3854473
Compare
|
@GaetanLepage I found a way to fix the tests ! all good. |
|
|
|
|
|
Oops, went to bed, feel free to fix it or I'll do it tomorrow. |
I can't Tried checking out with |
drupol
force-pushed
the
push-rqopnworpork
branch
from
3854473 to
8caab63
Compare
|
GaetanLepage
approved these changes
Dec 18, 2024
drupol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.