nixos/networkd: expose RapidCommit in DHCPv4 network unit section #366038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
It would be fantastic if this got a backport, but I've no idea where to begin with that. |
github-actions
bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12. first-time contribution
|
Tested & validated as working on |
philiptaron
requested changes
Dec 18, 2024
Disabling this option is required to obtain a DHCPv4 lease from some old/misconfigured DHCP servers. This was already exposed for DHCPv6.
lattwood
force-pushed
the
lattwood/rapidcommit_dhcpv4
branch
from
49a315e to
6c32471
Compare
philiptaron
approved these changes
Dec 18, 2024
| @@ -877,6 +877,7 @@ let | |||
| "IAID" | |||
| "RequestBroadcast" | |||
| "RouteMetric" | |||
| "RapidCommit" | |||
There was a problem hiding this comment.
Docs (for anyone coming on this PR later, no need to update the PR for this.)
|
Hi @philiptaron, what's involved in backporting this to 24.11? It looks like adding a label to this PR/issue and rerunning the action would do it but I don't have permissions. 
|
Yep, did it. |
|
Successfully created backport PR for |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
RapidCommitoption in the[DHCPv4]section ofsystemd-networkdnetwork units. Disabling this option is required to obtain a DHCPv4 lease from some old/misconfigured DHCP servers. This was already exposed for DHCPv6.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.