fedistar: init at 1.11.0 #366043
Open
fedistar: init at 1.11.0 #366043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
gepbird
reviewed
Jan 15, 2025
gepbird
suggested changes
Jan 20, 2025
gepbird
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Binary works and changes LGTM, thanks!
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366043
x86_64-linux
✅ 1 package built:
- fedistar
gepbird
added
the
12.approvals: 1
13 tasks
|
@gepbird When this is merged in, do you want me to move it back to pnpm10? It builds fine with pnpm10, it's just the output hash that is different every time. |
Sure! |
It's worth noting that if they ever decide to add tray icons to the program, it will most likely suffer the same fate as cinny-desktop, where it will not be supported (see NixOS#357482)
|
Went ahead and moved it back to pnpm_10, and it worked perfectly! |
wegank
removed
the
12.approvals: 1
gepbird
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366043
x86_64-linux
✅ 1 package built:
- fedistar
gepbird
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's worth noting that if they ever decide to add tray icons to the program, it will most likely suffer the same fate as cinny-desktop, where it will not be supported (see #357482)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.