Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wluma: 4.4.0 → 4.5.1 #366110

Merged
merged 1 commit into from
Dec 22, 2024
Merged

wluma: 4.4.0 → 4.5.1 #366110

merged 1 commit into from
Dec 22, 2024

Conversation

Rishik-Y
Copy link
Contributor

@Rishik-Y Rishik-Y commented Dec 18, 2024

Adding support for 24.11

Tests: Ran it multiple times and is already present in NisOS unstable channel just simply updated

Package Information

  • Package name: wluma
  • Latest released version: 4.5.1 (for 24.11)
  • Current version on the unstable channel: 4.5.1
  • Current version on the stable/release channel: 4.4.0

Changes: Minor changes so Latest version works in 24.11 stable

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Notify maintainers

@yshym @jmc-figueira @Atemu

Adding support for 24.11
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 18, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 18, 2024
@Atemu
Copy link
Member

Atemu commented Dec 18, 2024

Hi, does this bump fix any significant bugs that users cannot be expected to bear until 25.05?

We generally only backport to stable if there is good reason to. Users who want the latest and greatest at all times should use the rolling channel.

Regardless of that please adjust your commit messages to follow the commit conventions where you prefix the commit message with the name of the component you changed followed by a column.

e.g. component: change x about it in order to y or package: 0.1.0 -> 0.2.0

Reword your commits using an interactive rebase and then force-push them to your branch.

Please ideally also just cherry-pick the commit that bumped wluma in unstable using -X. It simplest to just add (or request) a backport label on the original PR which makes a bot create a backport PR automatically.

@ofborg ofborg bot requested review from jmc-figueira, yshym and Atemu December 18, 2024 20:06
@Rishik-Y Rishik-Y changed the title Update wluma 4.4.0 → 4.5.1 (in 24.11) wluma 4.4.0 → 4.5.1 Dec 19, 2024
@Rishik-Y Rishik-Y changed the title wluma 4.4.0 → 4.5.1 wluma: 4.4.0 → 4.5.1 Dec 19, 2024
@Rishik-Y
Copy link
Contributor Author

Hi @Atemu,
Yes it fixes Major bugs,
As in wluma by default will crash on Hyprland or other some wlroots based compositor,
but the version change fixes that issue by changing the default config..
Some memory leaks..
and many other minor fixes!

Here is the changelog if you would like
maximbaz/wluma@4.4.1...4.5.0

Thx to let me know about naming convention,
I just learnt about updating packages (Just to fix this issue)
But changed my commit message..

Please ideally also just cherry-pick the commit that bumped wluma in unstable using -X. It simplest to just add (or request) a backport label on the original PR which makes a bot create a backport PR automatically.

Sorry about this as well,
Will learn it and do this, moving forward..

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366110


x86_64-linux

✅ 1 package built:
  • wluma

@wolfgangwalther
Copy link
Contributor

Thanks for adjusting the PR title. However, we need a matching commit message, too - and currently this is still not following the right format.

But, since this is only a single commit, I can adjust the commit message via squash merge.

@wolfgangwalther wolfgangwalther merged commit a1b8c11 into NixOS:release-24.11 Dec 22, 2024
70 checks passed
@Rishik-Y
Copy link
Contributor Author

Thanks for adjusting the PR title. However, we need a matching commit message, too - and currently this is still not following the right format.

But, since this is only a single commit, I can adjust the commit message via squash merge.

Sorry about that (Since this was my first commit)
Will make sure to not make such mistakes..
Thanks for merging btw.

@Rishik-Y Rishik-Y deleted the patch-1 branch December 23, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants