-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wluma: 4.4.0 → 4.5.1 #366110
wluma: 4.4.0 → 4.5.1 #366110
Conversation
Adding support for 24.11
Hi, does this bump fix any significant bugs that users cannot be expected to bear until 25.05? We generally only backport to stable if there is good reason to. Users who want the latest and greatest at all times should use the rolling channel. Regardless of that please adjust your commit messages to follow the commit conventions where you prefix the commit message with the name of the component you changed followed by a column. e.g. Reword your commits using an interactive rebase and then force-push them to your branch. Please ideally also just cherry-pick the commit that bumped wluma in unstable using |
Hi @Atemu, Here is the changelog if you would like Thx to let me know about naming convention,
Sorry about this as well, |
|
Thanks for adjusting the PR title. However, we need a matching commit message, too - and currently this is still not following the right format. But, since this is only a single commit, I can adjust the commit message via squash merge. |
Sorry about that (Since this was my first commit) |
Adding support for 24.11
Tests: Ran it multiple times and is already present in NisOS unstable channel just simply updated
Package Information
Changes: Minor changes so Latest version works in 24.11 stable
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Notify maintainers
@yshym @jmc-figueira @Atemu