bigquery-emulator: init at 0.6.6 #366144
Merged
bigquery-emulator: init at 0.6.6 #366144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarantoj
force-pushed
the
init-bigquery-emulator
branch
from
dd40816 to
c70d924
Compare
tarantoj
force-pushed
the
init-bigquery-emulator
branch
from
c70d924 to
1aa447b
Compare
tarantoj
force-pushed
the
init-bigquery-emulator
branch
from
1aa447b to
e9971de
Compare
tarantoj
changed the title
|
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4976 |
thiagokokada
approved these changes
Dec 19, 2024
|
|
|
Comment on lines
+16
to
+19
| name = pname; | ||
| src = fetchFromGitHub { | ||
| owner = "goccy"; | ||
| repo = pname; |
There was a problem hiding this comment.
pname should not be used like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bigquery-emulator
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.