-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anydesk: add missing dependencies #366250
anydesk: add missing dependencies #366250
Conversation
But thats nothing what we can fix right? closed source software 🤔 |
Most likely, but there's a chance it's using some environment variables from the user or it's lacking some. I've got a similar problem with another proprietary software, cisco packet tracer, which had colors messed up. The "fix" was to disable my QT dark theme (which just added some env vars). Does it happen to you @shyim @JarvisCraft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4778141
to
3a1d1b9
Compare
It might be worth checking if Anydesk still depends on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth checking if Anydesk still depends on
gnome2
etc?
GUI opens without it, thanks @TheArcaneBrony !
diff --git a/pkgs/by-name/an/anydesk/package.nix b/pkgs/by-name/an/anydesk/package.nix
index 5873cb7cd3d8..c9b5b8e7ef52 100644
--- a/pkgs/by-name/an/anydesk/package.nix
+++ b/pkgs/by-name/an/anydesk/package.nix
@@ -10,7 +10,6 @@
cairo,
gdk-pixbuf,
glib,
- gnome2,
gtk3,
dbus,
harfbuzz,
@@ -57,7 +56,6 @@ stdenv.mkDerivation (finalAttrs: {
libz
stdenv.cc.cc
pango
- gnome2.gtkglext
libGLU
libGL
minizip
@@ -118,11 +116,6 @@ stdenv.mkDerivation (finalAttrs: {
--set-rpath "${lib.makeLibraryPath finalAttrs.buildInputs}" \
$out/bin/anydesk
- # pangox is not actually necessary (it was only added as a part of gtkglext)
- patchelf \
- --remove-needed libpangox-1.0.so.0 \
- $out/bin/anydesk
-
wrapProgram $out/bin/anydesk \
--prefix PATH : ${
lib.makeBinPath [
3a1d1b9
to
b5f3b26
Compare
@TheArcaneBrony, @gepbird, Good catch, thanks! Pushed this patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested binary, looks good
Things done
Before this,
anydesk
is not runnable due to unsatisfied dynamic library dependencies.This fixes the issue by adding these dependencies.
The fix also sets
GDK_BACKEND=x11
to resolve issue:and invalid scaling.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.