super-slicer: fix STEP importer library not found #366654
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srounce
force-pushed
the
fix-super-slicer-step-import
branch
from
8e2edda to
82dd9a7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5003 |
|
Thanks and Merry Christmas |
|
Doesn't seem to build being rebased on master on x86_64-linux
|
|
Hmm that's weird, I haven't changed anything to do with the build literally just reinstated the postInstall step from prusa-slicer to move the library to the correct path. It seems that the build is broken on master regardless of these changes. |
srounce
force-pushed
the
fix-super-slicer-step-import
branch
from
82dd9a7 to
7b3b08d
Compare
|
After a bit more looking around it seems the compilation error was fixed in this revision: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added postInstall step to copy OCCTWrapper.so to the lib directory fixing the
OCCTWrapper.so not founderror when importing STEP files.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.