Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak tts #366756

Merged
merged 7 commits into from
Dec 22, 2024
Merged

Unbreak tts #366756

merged 7 commits into from
Dec 22, 2024

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Dec 20, 2024

By mostly switching to a maintained fork.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 20, 2024
@jbgi jbgi requested review from mweinelt, wegank and Mic92 and removed request for mweinelt December 20, 2024 09:46
@nix-owners nix-owners bot requested a review from natsukium December 20, 2024 09:47
@jbgi jbgi force-pushed the tts-fixes branch 2 times, most recently from 1177abf to 2109463 Compare December 20, 2024 15:37
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2024

Please undraft, once you it's working for you.

@Mic92 Mic92 marked this pull request as draft December 20, 2024 16:13
@jbgi jbgi marked this pull request as ready for review December 20, 2024 17:31
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 21, 2024
@ofborg ofborg bot requested review from junjihashimoto and Mic92 December 21, 2024 03:58
@ofborg ofborg bot requested a review from Mic92 December 22, 2024 04:19
@Mic92 Mic92 merged commit e2680ee into NixOS:master Dec 22, 2024
34 of 36 checks passed
@ofborg ofborg bot requested a review from samuela December 22, 2024 23:22
@jbgi
Copy link
Contributor Author

jbgi commented Dec 28, 2024

@Mic92 could we backport this PR?

@Mic92 Mic92 added the backport release-24.11 Backport PR automatically label Dec 28, 2024
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 28, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eginhard eginhard eginhard left review comments

@wegank wegank Awaiting requested review from wegank

@mweinelt mweinelt Awaiting requested review from mweinelt

@natsukium natsukium Awaiting requested review from natsukium

@junjihashimoto junjihashimoto Awaiting requested review from junjihashimoto

@Mic92 Mic92 Awaiting requested review from Mic92

@samuela samuela Awaiting requested review from samuela

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbgi @Mic92 @eginhard