Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

famistudio: 4.2.1 -> 4.3.0 #366804

Merged
merged 4 commits into from
Dec 31, 2024
Merged

famistudio: 4.2.1 -> 4.3.0 #366804

merged 4 commits into from
Dec 31, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 20, 2024 •
edited
Loading

Release: https://github.com/BleuBleu/FamiStudio/releases/tag/4.3.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Dec 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366804

x86_64-linux

✅ 1 package built:
  • famistudio

@gepbird gepbird requested a review from OPNA2608 December 20, 2024 17:43
@gepbird gepbird force-pushed the famistudio-4.3.0 branch 2 times, most recently from acc6989 to 49fa034 Compare December 22, 2024 22:09
OPNA2608
OPNA2608 requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I wrote a comment on Christmas but forgot to submit it before leaving for festivities!

pkgs/by-name/fa/famistudio/update.sh Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from OPNA2608 December 27, 2024 21:29
OPNA2608
OPNA2608 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 31, 2024
@OPNA2608 OPNA2608 merged commit 0b56c05 into NixOS:master Dec 31, 2024
44 of 45 checks passed
@gepbird gepbird deleted the famistudio-4.3.0 branch December 31, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gepbird @OPNA2608