Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump/jetbrains 2024.3.1.1 #366856

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Bump/jetbrains 2024.3.1.1 #366856

merged 2 commits into from
Jan 9, 2025

Conversation

jamesward
Copy link
Contributor

@jamesward jamesward commented Dec 20, 2024 •
edited
Loading

Bump jetbrains IDEs to latest:

    jetbrains: 2024.3 -> 2024.3.3
    
    jetbrains.aqua: 2024.3 -> 2024.3.1
    jetbrains.clion: 2024.3.1 -> 2024.3.1.1
    jetbrains.datagrip: 2024.3.2 -> 2024.3.3
    jetbrains.dataspell: 2024.3.1 -> 2024.3.1.1
    jetbrains.gateway: 2024.3.1 -> 2024.3.1.1
    jetbrains.idea-community: 2024.3.1 -> 2024.3.1.1
    jetbrains.idea-ultimate: 2024.3.1 -> 2024.3.1.1
    jetbrains.phpstorm: 2024.3.1 -> 2024.3.1.1
    jetbrains.pycharm-community: 2024.3.1 -> 2024.3.1.1
    jetbrains.pycharm-professional: 2024.3.1 -> 2024.3.1.1
    jetbrains.rider: 2024.3.2 -> 2024.3.3
    jetbrains.ruby-mine: 2024.3.1 -> 2024.3.1.1
    jetbrains.rust-rover: 2024.3.1 -> 2024.3.2
    jetbrains.webstorm: 2024.3.1 -> 2024.3.1.1
    jetbrains.writerside: 2024.3 EAP -> 2024.3 EAP

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@theCapypara
Copy link
Member

Thanks!
#366290 should be merged before and then you should re-run the plugin update script to make sure plugins for source builds are also up-to-date

@jamesward jamesward marked this pull request as draft December 20, 2024 22:09
@theCapypara theCapypara mentioned this pull request Jan 8, 2025
Closed
13 tasks
@leona-ya
Copy link
Member

leona-ya commented Jan 9, 2025

#366290 is now merged. Can you please rerun the update script including the plugin update.

@jamesward
jetbrains: 2024.3 -> 2024.3.3
89caef1 
jetbrains.aqua: 2024.3 -> 2024.3.1
jetbrains.clion: 2024.3.1 -> 2024.3.1.1
jetbrains.datagrip: 2024.3.2 -> 2024.3.3
jetbrains.dataspell: 2024.3.1 -> 2024.3.1.1
jetbrains.gateway: 2024.3.1 -> 2024.3.1.1
jetbrains.idea-community: 2024.3.1 -> 2024.3.1.1
jetbrains.idea-ultimate: 2024.3.1 -> 2024.3.1.1
jetbrains.phpstorm: 2024.3.1 -> 2024.3.1.1
jetbrains.pycharm-community: 2024.3.1 -> 2024.3.1.1
jetbrains.pycharm-professional: 2024.3.1 -> 2024.3.1.1
jetbrains.rider: 2024.3.2 -> 2024.3.3
jetbrains.ruby-mine: 2024.3.1 -> 2024.3.1.1
jetbrains.rust-rover: 2024.3.1 -> 2024.3.2
jetbrains.webstorm: 2024.3.1 -> 2024.3.1.1
jetbrains.writerside: 2024.3 EAP -> 2024.3 EAP
@jamesward
jetbrains.plugins: update
0eb2822
@jamesward jamesward force-pushed the bump/jetbrains-2024.3.1.1 branch from dc70451 to 0eb2822 Compare January 9, 2025 15:33
@jamesward jamesward marked this pull request as ready for review January 9, 2025 15:35
@jamesward jamesward marked this pull request as draft January 9, 2025 15:46
@jamesward
Copy link
Contributor Author

I rebased on master and re-ran the update script. IntelliJ seems to be working as expected.

@jamesward jamesward marked this pull request as ready for review January 9, 2025 15:49
leona-ya
leona-ya approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much!

@leona-ya leona-ya added the backport release-24.11 Backport PR automatically label Jan 9, 2025
@leona-ya leona-ya merged commit 989560e into NixOS:master Jan 9, 2025
38 of 42 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 9, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-366856-to-release-24.11 origin/release-24.11
cd .worktree/backport-366856-to-release-24.11
git switch --create backport-366856-to-release-24.11
git cherry-pick -x 89caef1ff41429e49c5eacdf79bdc4b5458429a5 0eb282214611ef0d93fe00735fb77a359b2d0502

@leona-ya leona-ya added backport release-24.11 Backport PR automatically and removed backport release-24.11 Backport PR automatically labels Jan 9, 2025
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 9, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 9, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leona-ya leona-ya leona-ya approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

@theCapypara theCapypara Awaiting requested review from theCapypara

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesward @theCapypara @leona-ya