goshs: init at 1.0.1 #366872
goshs: init at 1.0.1 #366872
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
ofborg
bot
added
8.has: package (new)
github-actions
bot
added
10.rebuild-darwin: 0
|
Just for curiosity sake, what this does that rclone doesn't do? Rclone has |
I was really looking for a really simple file upload portal but it turns out surprisingly hard.
This is the only thing works for me so far (except it doesn't handle file timestamp but nor does most alternatives I've seen so far). |
| "-s" | ||
| "-w" | ||
| ]; | ||
|
|
There was a problem hiding this comment.
passthru.updateScript = gitUpdater { rev-prefix = "v"; };
|
|
||
| vendorHash = "sha256-6UaKh2UUyGqOriAaMhiEFr20R4W/ZWxQXtXnm/BVHOc="; | ||
|
|
||
| ldflags = [ |
There was a problem hiding this comment.
These two flags disable symbol generation and DWARF generation respectively and are AFAICT fairly standard for release-build Go packages. No need to strip them out later if we never generate them to begin with
| # --- FAIL: TestGetIPv4Addr (0.00s) | ||
| # utils_test.go:62: route ip+net: no such network interface | ||
| badPlatforms = lib.platforms.darwin; | ||
| maintainers = with lib.maintainers; [ seiarotg ]; |
There was a problem hiding this comment.
maintainers = [ lib.maintainers.seiarotg ];
|
@ofborg eval |
|
Weird |
| description = "Simple, yet feature-rich web server written in Go"; | ||
| homepage = "https://goshs.de"; | ||
| license = lib.licenses.mit; | ||
| platforms = lib.platforms.all; |
There was a problem hiding this comment.
I seriously doubt this (I don't think Go compiles for all platforms Nixpkgs supports). If this is supposed to work for all platforms Go supports, then just leave it blank as buildGoModule will provide a sensible default
| platforms = lib.platforms.all; | ||
| # --- FAIL: TestGetIPv4Addr (0.00s) | ||
| # utils_test.go:62: route ip+net: no such network interface | ||
| badPlatforms = lib.platforms.darwin; |
There was a problem hiding this comment.
Hnnrgh, feels weird to mark all Darwin builds as broken when only one test is failing. Should we just disable that test on Darwin? (Also, just a hunch, but given this is about networking and only happens on Darwin, try setting __darwinAllowLocalNetworking to true)
| "-s" | ||
| "-w" | ||
| ]; | ||
|
|
There was a problem hiding this comment.
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| doInstallCheck = true; | |
|
|
||
| meta = { | ||
| description = "Simple, yet feature-rich web server written in Go"; | ||
| homepage = "https://goshs.de"; |
There was a problem hiding this comment.
| homepage = "https://goshs.de"; | |
| homepage = "https://goshs.de"; | |
| changelog = "https://github.com/patrickhener/goshs/releases/tag/v${version}"; |
Adds package
goshs, the simple, yet feature-rich web server.See:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.