-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add gcc offloading to GPUs #366903
Draft
viric
wants to merge
4
commits into
master
Choose a base branch
from
gcc-offload
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RFC: Add gcc offloading to GPUs #366903
+97
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: haskell
6.topic: qt/kde
6.topic: kernel
The Linux kernel
8.has: documentation
This PR adds or changes documentation
8.has: changelog
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: emacs
Text editor
6.topic: printing
6.topic: policy discussion
6.topic: ruby
6.topic: vim
6.topic: ocaml
6.topic: xfce
The Xfce Desktop Environment
6.topic: fetch
6.topic: stdenv
Standard environment
6.topic: nodejs
6.topic: hardware
6.topic: coq
"A formal proof management system"
6.topic: nixos-container
Imperative and declarative systemd-nspawn containers
6.topic: pantheon
The Pantheon desktop environment
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: lua
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: module system
About "NixOS" module system internals
6.topic: systemd
6.topic: java
Including JDK, tooling, other languages, other VMs
6.topic: vscode
6.topic: lib
The Nixpkgs function library
labels
Dec 20, 2024
nix-owners
bot
requested review from
alyssais,
Artturin,
dtzWill,
emilazy,
lovek323,
philiptaron,
reckenrode,
RossComputerGuy,
rrbutani and
sternenseemann
December 20, 2024 19:16
viric
added
the
6.topic: cross-compilation
Building packages on a different platform than they will be used on
label
Dec 20, 2024
ofborg
bot
added
2.status: merge conflict
This PR has merge conflicts with the target branch
8.has: package (new)
This PR adds a new package
and removed
2.status: merge conflict
This PR has merge conflicts with the target branch
labels
Dec 21, 2024
This should target master instead, right? |
sure - I simply was doing the experiments on 24.11. This is not meant for merging yet. I only wanted to start the discussion on the bases of a dirty but working piece. |
But it cannot target gfx1103 - that probably requires the rocmPackages.llvm that is broken.
ofborg
bot
added
2.status: merge conflict
This PR has merge conflicts with the target branch
and removed
2.status: merge conflict
This PR has merge conflicts with the target branch
labels
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: cross-compilation
Building packages on a different platform than they will be used on
6.topic: lib
The Nixpkgs function library
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a dirty attempt to bring the "amdgcn-amdhsa" gcc offloading to nixpkgs. It's quite dirty but I wanted to have some 'working' base so we can translate to the structures that will handle this well. I was following the instructions in https://gcc.gnu.org/wiki/Offloading#Examples
Some of the difficulties are:
With this I could build a simple "openmp target" example code in the clang page about Offloading: https://clang.llvm.org/docs/OffloadingDesign.html#offloading-example
@Ericson2314 what is your opinion how can we make these things fit? Ideally we would want AMD/NVIDIA offload in gcc, and AMD/NVIDIA/Intel offload in clang.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.