Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] incus: test refactor, fix CSM #366918

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[Backport release-24.11] incus: test refactor, fix CSM #366918

merged 3 commits into from
Dec 20, 2024

Conversation

adamcstephens
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 20, 2024
@adamcstephens
incus: refactor tests
b93a71d 
(cherry picked from commit d7552b8)
@adamcstephens
incus: fix CSM support
5b6548d 
(cherry picked from commit 6cd3dd3)
@adamcstephens
nixos/incus: seabios is x86_64 only
4066a53 
(cherry picked from commit cbe221c)
@adamcstephens
Copy link
Contributor Author

adamcstephens commented Dec 20, 2024 •
edited
Loading

aarch64 run of nixosTests.incus.all
/nix/store/z296a3hjmsb53naqpsf7mds25ibafq0g-vm-test-run-incus

aarch64 run of nixosTests.incus-lts.all
/nix/store/wzca9mqr1mmjy92x778rkdfdga3a7c2r-vm-test-run-incus-lts

@adamcstephens
Copy link
Contributor Author

x86 both suites
/nix/store/4ji46hbbdalm0aad3mqrrxic2dk2lf5h-vm-test-run-incus
/nix/store/yd7r8zj9kg9z35rvm1gilf81fjlj5njd-vm-test-run-incus-lts

@adamcstephens adamcstephens merged commit 1c6e20d into NixOS:release-24.11 Dec 20, 2024
21 of 23 checks passed
@adamcstephens adamcstephens deleted the push-mvzrrzwnnrmq branch December 20, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamcstephens