Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppp: adopt, cleanups, add systemd sd-notify & PAM support #366940

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Dec 20, 2024

I am using the package myself and as its lacking currently a maintainer, I am volunteering to do so.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 20, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 20, 2024
@stv0g stv0g changed the title Adopting ppp ppp: adopt, cleanups, add systemd sd-notify & PAM support Dec 20, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 2501-5000 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 20, 2024
@stv0g stv0g mentioned this pull request Dec 20, 2024
13 tasks
@stv0g stv0g requested review from mweinelt and peterhoeg December 20, 2024 22:37
@7c6f434c
Copy link
Member

Looks like module adoption is using pkgs outside of the scope called with this parameter?

@stv0g
Copy link
Contributor Author

stv0g commented Dec 21, 2024

Looks like module adoption is using pkgs outside of the scope called with this parameter?

Sorry, I should have tested the NixOS test locally. It now passed on aarch64-linux.

@stv0g stv0g changed the base branch from master to staging December 21, 2024 18:17
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ and removed 10.rebuild-darwin: 1-10 labels Dec 21, 2024
@7c6f434c 7c6f434c merged commit cd6c393 into NixOS:staging Dec 23, 2024
52 of 53 checks passed
@stv0g stv0g deleted the adopting-ppp branch December 23, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants