Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/monica: fix email configuration bug #366946

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

sehqlr
Copy link
Contributor

@sehqlr sehqlr commented Dec 20, 2024

This is a one-line change to make Monica's email configuration work, and will close #345193. This is my first time contributing to nixpkgsI have not done a lot of testing since I'm not 100% on how to do all of it. I'm more than happy to go through a more rigorous process if need be.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Dec 20, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 20, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 20, 2024
@lucasew
Copy link
Contributor

lucasew commented Dec 21, 2024

I don't know about the domain of this package.

BTW for a lot of services there is tests, called NixOS tests, that basically work by using a python script to interact with a set of VMs. I'm running one of them for monica.

And a suggestion: there is a naming convention on how to name PRs and commits. This case would be something like nixos/monica: fix email configuration bug.

Welcome to nixpkgs!

@sehqlr
Copy link
Contributor Author

sehqlr commented Dec 25, 2024

there is a naming convention on how to name PRs and commits

Duly noted, I'll refer back to this commit when needed. Thanks

@sehqlr sehqlr changed the title Fix the Monica email configuration bug nixos/monica: fix email configuration bug Dec 25, 2024
@Silver-Golden
Copy link
Member

Came across this issue myself last night, glad to see there is a patch in progress for it.

Taking a look at the issue @Guekka may want to give the approval for this (I know he said go ahead in the other thread but always good to have it here)

@Guekka
Copy link
Contributor

Guekka commented Dec 28, 2024

Looks good to me. @sehqlr I see you added your name to maintainers. You can make yourself a maintainer of monica if you want, especially since I no longer use this module

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2024
@ck3d ck3d merged commit ae09407 into NixOS:master Dec 31, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monica module creates an incorrect configuration for sending emails
7 participants