config.boot.loader: Add timestampFormat #366958
Open
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option
config.boot.loadertimestampFormat
to change how the build timestamp is displayed in bootloaders, as discussed here https://www.reddit.com/r/NixOS/comments/17ilg97/anyone_know_how_to_show_the_time_of_configuration/This is my first pull request so I'm not sure if it's alright that I skipped some things, like I don't think it needs test (I can't find any existing tests for the modules anyway), and so I need to update the changelog?
Thanks :)
Things done
loader
substituteAll
in .nix filesBuild settings tested
timestampFormat = "%F %H:%M"
;timestampFormat
unset;timestampFormat = "%F %H:%M"
;timestampFormat
unset;Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/
)25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.