Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brltty: 6.6 -> 6.7 #366967

Merged
merged 1 commit into from
Dec 22, 2024
Merged

brltty: 6.6 -> 6.7 #366967

merged 1 commit into from
Dec 22, 2024

Conversation

bramd
Copy link
Contributor

@bramd bramd commented Dec 21, 2024

Update BRLTTY from 6.6 to 6.7. No breaking changes, see changelog at https://brltty.app/doc/ChangeLog.txt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 21, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 21, 2024
@xanderio xanderio changed the title Update BRLTTY from 6.6 to 6.7 brltty: 6.6 -> 6.7 Dec 21, 2024
@xanderio xanderio added the backport release-24.11 Backport PR automatically label Dec 21, 2024
@donovanglover
Copy link
Member

ofborg is failing with the following:

./screen.c:42:10: fatal error: term.h: No such file or directory
   42 | #include <term.h>
      |          ^~~~~~~~
compilation terminated.
make[2]: *** [Makefile:57: screen.o] Error 1
make[2]: Leaving directory '/build/brltty-6.7/Drivers/Screen/FileViewer'
make[1]: *** [Makefile:1092: screen-drivers] Error 1
make[1]: Leaving directory '/build/brltty-6.7/Programs'
make: *** [Makefile:49: all] Error 2
error: builder for '/nix/store/qwnkxhp80k49gvvra36vjgxf5a1h6lbm-brltty-6.7.drv' failed with exit code 2;

@bramd
Copy link
Contributor Author

bramd commented Dec 21, 2024

@donovanglover I just saw that as well, will look into it.

@bramd bramd force-pushed the brltty-6.7 branch 2 times, most recently from a4c3a49 to dcbd0b0 Compare December 21, 2024 18:55
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Dec 21, 2024
@bramd
Copy link
Contributor Author

bramd commented Dec 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366967


x86_64-linux

✅ 3 packages built:
  • brltty
  • orca
  • pantheon.elementary-session-settings

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 22, 2024
@donovanglover donovanglover merged commit aa35b51 into NixOS:master Dec 22, 2024
58 of 59 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 22, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants