nixos/ntpd: fix permissions error when creating drift file #367064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes "frequency file /var/lib/ntp/ntp.drift.TEMP: Permission denied". Creating a directory via StateDirectory makes that directory /var/lib/ntp owned by root:root. However, when running ntpd we change to user ntp (see ntpFlags), so the process cannot actually use that directory. Actually creating a home directory for the user at that location solves that problem.
github-actions
bot
added
6.topic: nixos
|
The error only occurs after a while, so keeping this as draft until I can confirm that the error is indeed fixed. |
github-actions
bot
added
10.rebuild-darwin: 0
chewblacka
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Seems good to me. Tested with nix-build nixos/tests/ntpd.nix and that produced a successful outcome:
(finished: must succeed: su -s /bin/sh -c "touch /var/lib/ntp/ntp.drift" ntp, in 0.19 seconds)
(finished: run the VM test script, in 26.40 seconds)
test script finished in 26.48s
|
I had thought of a different way of solving this problem, but this works too! |
pyrox0
approved these changes
Dec 22, 2024
pyrox0
added
12.approvals: 1
chewblacka
added
12.approvals: 2
thoughtpolice
approved these changes
Dec 22, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "frequency file /var/lib/ntp/ntp.drift.TEMP: Permission denied".
Creating a directory via
StateDirectorymakes that directory/var/lib/ntp ownedbyroot:root. However, when runningntpdwe change to userntp(seentpFlags), so the process cannot actually use that directory.Actually creating a home directory for the user at that location solves that problem.
Fixes #366475 .
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.