Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bmputil: init at 0.1.3 #367176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bmputil: init at 0.1.3 #367176

wants to merge 2 commits into from

Conversation

shimunn
Copy link
Contributor

@shimunn shimunn commented Dec 21, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 21, 2024
@shimunn shimunn force-pushed the bmputil branch 4 times, most recently from 24d4ec1 to d4d5e37 Compare December 21, 2024 18:39
makuru-org
makuru-org suggested changes Dec 21, 2024
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 22, 2024
@shimunn shimunn force-pushed the bmputil branch 3 times, most recently from 84123af to 652331a Compare December 22, 2024 10:57
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 22, 2024
pluiedev
pluiedev suggested changes Dec 25, 2024
View reviewed changes
pkgs/by-name/bm/bmputil/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bm/bmputil/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bm/bmputil/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bm/bmputil/package.nix Show resolved Hide resolved
@shimunn shimunn requested a review from pluiedev December 29, 2024 09:38
pluiedev
pluiedev approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for small nit (the PR title and the main commit should be retitled to bmputil: init at 0.1.3, and the maintainer commit should say maintainers: add shimun)

pkgs/by-name/bm/bmputil/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bm/bmputil/50-blackmagic.conf Outdated
@@ -0,0 +1 @@
SUBSYSTEMS=="usb", ATTRS{idVendor}=="1d50", ATTRS{idProduct}=="6018", GROUP="plugdev", MODE="0666"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: where's this file from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had this floating around in my system for a while, don't really now where it's from

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to find out where it came from then, since we don't really want to vendor random files ourselves if we can

Copy link
Contributor Author

@shimunn shimunn Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably form here would it be sensible to include the line via pkgs.blackmagic.src ?

Copy link
Contributor

@pluiedev pluiedev Dec 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it, looks like we should install all the udev rules found inside driver/ then

(EDIT: looks like you should install either the plugdev or the uucp variant, depending on your distro — NixOS appears to use the former, although I think the newer uaccess method might work)

@FliegendeWurst FliegendeWurst changed the title Bmputil bmputil: init at 0.1.3 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makuru-org makuru-org makuru-org requested changes

@pluiedev pluiedev pluiedev approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shimunn @FliegendeWurst @pluiedev @makuru-org