Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcodegen: init at 2.42.0 #367199

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

Samasaur1
Copy link
Member

@Samasaur1 Samasaur1 commented Dec 21, 2024

Adds XcodeGen. Closes #208816

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Samasaur1 Samasaur1 mentioned this pull request Dec 21, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 21, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 22, 2024
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
@Samasaur1
Copy link
Member Author

That failed eval is actually a git error, not sure what's going on there

pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xc/xcodegen/package.nix Outdated Show resolved Hide resolved
@Samasaur1
Copy link
Member Author

I made the changes you suggested, but I have a question about passthru.updateScript. I was under the impression that the default was to use nix-update-script. Are you just suggesting that I be explicit here or am I wrong about the default behavior?

@GaetanLepage
Copy link
Contributor

I made the changes you suggested, but I have a question about passthru.updateScript. I was under the impression that the default was to use nix-update-script. Are you just suggesting that I be explicit here or am I wrong about the default behavior?

No, AFAIK there is no default (in general: all packages under pythonPackages have nix-update-script by default). So it is useful to explicitly add it.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367199


x86_64-darwin

✅ 1 package built:
  • xcodegen

aarch64-darwin

✅ 1 package built:
  • xcodegen

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DimitarNestorov DimitarNestorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested basic functionality with following commands, works fine

$ echo "name: Test" > project.yml
$ xcodegen --version
Version: 2.42.0
$ xcodegen
⚙️  Generating plists...
⚙️  Generating project...
No "base" settings found
No "debug config" settings found
No "release config" settings found
⚙️  Writing project...
Created project at /Users/dimitar/.cache/nixpkgs-review/pr-367199/Test.xcodeproj

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367199


aarch64-darwin

✅ 1 package built:
  • xcodegen

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 29, 2024
@GaetanLepage
Copy link
Contributor

Thanks for testing @DimitarNestorov !

@GaetanLepage GaetanLepage merged commit ceb815c into NixOS:master Dec 29, 2024
42 of 43 checks passed
@Samasaur1 Samasaur1 deleted the push-rwkyqtmyyork branch December 29, 2024 09:12
@DimitarNestorov DimitarNestorov mentioned this pull request Dec 29, 2024
13 tasks
@DanielSincere
Copy link

DanielSincere commented Jan 18, 2025

Hello, love that xcodegen is supported here. However, it's not installed correctly. I'm getting the following errors when I run it, which results a different xcodeproj file when running xcodegen when installed by homebrew or mint. I cannot switch to Nix until this is resolved, as I rely on xcodegen.

Here is my error

Running `xcodegen generate -s ./xcodegen.yml`
⚙️  Generating plists...
⚙️  Generating project...
No "base" settings found
No "debug config" settings found
No "release config" settings found
No "iOS" settings found
⚙️  Writing project...

I see that @DimitarNestorov received a similar error here.

The missing files are static settings files packaged along side the xcodegen binary, from the SettingsPresets folder in source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XcodeGen
6 participants