kanidm: discern normal build from provisioning build and fix 1_3 patches #367230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
Why is the cargo hash different for the patched version? |
|
Ahh because pname is used by it. Looks like we can set |
oddlama
force-pushed
the
change-kanidm-provision-pname
branch
from
206dab1 to
e7e095e
Compare
|
That's definitely a better solution. I've updated the files. |
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-24.11 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
pnameof the kanidm package with provisioning package (as suggested by @adamcstephens)so we can better discern them when both are built in package updates.
I also fixed the secret provisioning build for the recently introduced 1_3 variant,
which requires the old patchfiles from pre 1_4 to apply properly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.