imager: init at 4.4-01 #367248
Open
imager: init at 4.4-01 #367248
+306
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of imager in the gildas package is outdated and not maintained anymore. It is superseded by the imager package.
|
|
Result of 2 packages built:
|
ofborg
bot
added
the
11.by: package-maintainer
pluiedev
suggested changes
Dec 25, 2024
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
|
Thanks for your detailed review @pluiedev ! I think I have addressed all your comments. |
|
pluiedev
suggested changes
Dec 26, 2024
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
Co-authored-by: Leah Amelia Chen <[email protected]>
|
Thanks again for your review @pluiedev. I have addressed your last comments. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New package. It replaces the version of imager that is included in the gildas package, which is outdated and not maintained anymore.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.