Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosModules.MooseFS: Format #367327

Merged
merged 1 commit into from
Dec 23, 2024
Merged

nixosModules.MooseFS: Format #367327

merged 1 commit into from
Dec 23, 2024

Conversation

liberodark
Copy link
Contributor

Only format of MooseFS

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 22, 2024
@liberodark
Copy link
Contributor Author

Hi,

Possible to backport this PR to 24.11 ?

Best Regards

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

Hi,

Possible to backport this PR to 24.11 ?

Best Regards

Just add the backport tag to the PR and the bot will create the PR automatically.

@GaetanLepage GaetanLepage added the backport release-24.11 Backport PR automatically label Dec 23, 2024
@GaetanLepage GaetanLepage merged commit 5cd2444 into NixOS:master Dec 23, 2024
38 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 23, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-367327-to-release-24.11 origin/release-24.11
cd .worktree/backport-367327-to-release-24.11
git switch --create backport-367327-to-release-24.11
git cherry-pick -x 10f638291737725eeafa36cb1f31704f42c73fc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liberodark @lucasew @GaetanLepage