-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 24.11]: nickel: 1.8.0 -> 1.9.1 #367328
[Backport 24.11]: nickel: 1.8.0 -> 1.9.1 #367328
Conversation
(cherry picked from commit 5c182f8) Signed-off-by: Matthias Beyer <[email protected]>
(cherry picked from commit 0085529) Signed-off-by: Matthias Beyer <[email protected]>
I really don't like this spam. |
That's still work in progress. Not sure how can I join the messages because each message comes from a different worker. |
Maybe you can dynamically start the different workers as nix remote builders and then run nixpkgs-review once with those remote builders set up? Then nixpkgs-review would report exactly once. |
v1.9.0 mentions a breaking change that requires manual intervention: https://github.com/tweag/nickel/releases/tag/1.9.0 Should this really be backported? |
On one hand you're absolutely right, on the other are we not responsible for keeping backwards compatibility of upstream software. If the software vendor cannot keep their backwards compatibility, that's not our problem, IMO,... at least not for software like this. Kernel, bootloader and such things are another topic, but this is not mission-critical software for nix/nixpkgs, so I'd say lets backport. |
Our contribution guidelines say something else:
|
The point is, that on a release branch, you should be able to update regularly to get all the security updates and keep your system safe - without breaking any of your workflows when doing so. The effort required to keep your system on the latest release branch should be minimal. |
I don't care enough. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.